Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add message for y interface of Binomial Polya #443

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

ismailsenoz
Copy link
Contributor

Add predictive distribution for BinomialPolya node

This PR implements the predictive distribution for the BinomialPolya node using Pólya-Gamma augmentation. The implementation includes:

  • Message passing rule for predictive distribution
  • Support for both analytical and Monte Carlo approximations

Key features:

  • Analytical approximation using mean of β when meta is nothing
  • Monte Carlo sampling with configurable number of samples when meta is provided
  • Returns Binomial distribution with averaged success probability

Files changed:

  • src/rules/binomial_polya/y.jl: Added predictive distribution rule
  • test/rules/binomial_polya/y_tests.jl: Tests

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.59%. Comparing base (edaa93c) to head (1632b8d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #443      +/-   ##
==========================================
+ Coverage   73.53%   73.59%   +0.05%     
==========================================
  Files         194      195       +1     
  Lines        5582     5593      +11     
==========================================
+ Hits         4105     4116      +11     
  Misses       1477     1477              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bvdmitri bvdmitri merged commit eff390c into main Jan 30, 2025
5 of 6 checks passed
@bvdmitri bvdmitri deleted the message_y_polya branch January 30, 2025 10:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants