1.x: replace non-serializable value of OnNextValue with its toString #4841
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When certain operators crash, they attach the current value to the exception via
OnErrorThrowable.addValueAsLastCause
, however, the value may not be serializable and the Throwable itself is, that causes a serialization exception.This PR replaces such values with their
String.valueOf
representation or the crash message iftoString
failed on that object.This was reported in #4562 with the suggestion of making the internal field
transient
. The problem with that is that upon deserialization, the field is null and there is no way of knowing if the original value was really null or just not serializable. UsingString.valueOf
at least gives a chance to know it was non-null and gets across some information about the original value.