Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

JavaFxObservable should provide a method to observe Node "event filters" #61

Open
pigelvy opened this issue Jan 15, 2018 · 4 comments
Open

Comments

@pigelvy
Copy link
Contributor

pigelvy commented Jan 15, 2018

Similar to JavaFxObservable#eventsOf(Node, EventType<T>), JavaFxObservable should have a method to observe Event objects during the capturing phase of event delivery. Internally, such method would use Node#addEventFilter(EventType, EventHandler) instead of Node#addEventHandler(EventType, EventHandler).

@thomasnield
Copy link
Collaborator

Huh... I don't think I've used events in that stage before. I'll take a look unless you want to put in a PR.

@thomasnield
Copy link
Collaborator

What would you propose the factory be called? Not quite clear what we are trying to accomplish here from an Rx perspective...

@pkrysztofiak
Copy link

pkrysztofiak commented Nov 4, 2018

If there is still any chance to add it I would suggest JavaFxObservable.eventsOf(Node, EventType, Phase)
where enum Phase {CAPTURING, BUBBLING} (as described https://docs.oracle.com/javafx/2/events/processing.htm#CEGJAAFD) or enum Phase {FILTERING, HANDLING)

@thomasnield
Copy link
Collaborator

@pkrysztofiak noted. I'm trying to get 2.11.x out (having BinTray deployment issues #73 ) and then I will start implementing these new features in both 2.8.x and 2.11.x.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants