Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Deprecated xmp tag in URL metadata #32

Closed
ReagentX opened this issue Nov 15, 2022 · 0 comments · Fixed by #219
Closed

Deprecated xmp tag in URL metadata #32

ReagentX opened this issue Nov 15, 2022 · 0 comments · Fixed by #219
Assignees
Labels
crate: cli Related to the CLI crate enhancement Requires updating an existing feature exporter Related to exporter processes html Related to HTML Export

Comments

@ReagentX
Copy link
Owner

Some webmasters include HTML in their sites' metadata:

https://darknetdiaries.com/transcript/21/

<meta property="og:description" content="Ira Winkler's specialty is assembling elite teams of special forces and intelligence officers to go after companies. Ira shares a story about a time he and his team broke into a global 5 company. A company so large that theft of intellictual property could result in billions of dollars of damage. <br><br>Ira's consulting company: <a href='http://www.securementem.com/'>Secure Mentum</a>.<br><br>His books: <a href='https://www.amazon.com/gp/product/0764584685/ref=as_li_tl?ie=UTF8&amp;camp=1789&amp;creative=9325&amp;creativeASIN=0764584685&amp;linkCode=as2&amp;tag=tunn01-20&amp;linkId=8f8a26b3c5fe68e6c8913ceea8adb0f5'>Spies Among Us</a>, <a href='https://www.amazon.com/gp/product/0128093161/ref=as_li_tl?ie=UTF8&amp;camp=1789&amp;creative=9325&amp;creativeASIN=0128093161&amp;linkCode=as2&amp;tag=tunn01-20&amp;linkId=ac08090c6d15b5ad2c77789fbcf50d56'>Advanced Persistent Security</a>, <a href='https://www.amazon.com/gp/product/0895263904/ref=as_li_tl?ie=UTF8&amp;camp=1789&amp;creative=9325&amp;creativeASIN=0895263904&amp;linkCode=as2&amp;tag=tunn01-20&amp;linkId=63e40c57a8bf8f04f077f55d6ed21455'>Through the Eyes of the Enemy</a>. ">

In the payload_data that ends up looking like this escaped html code:

image

If we got the whole string that would be fine, but iMessage truncates this data, so we end up getting some unclosed tags.

Rendering inside of <pre><code>…</code></pre> ends up rendering all of the escaped HTML, so I used an xmp tag in lieu of a code tag here to render the text properly. Since xmp is deprecated, we should do something else here. Ideally we can avoid using Javascript, as we want these pages to be printable to a PDF, and Javascript opens the door to non-printable features.

@ReagentX ReagentX added html Related to HTML Export enhancement Requires updating an existing feature labels Nov 15, 2022
@ReagentX ReagentX self-assigned this Nov 15, 2022
@ReagentX ReagentX added crate: cli Related to the CLI crate exporter Related to exporter processes labels Feb 5, 2023
@ReagentX ReagentX removed their assignment Sep 23, 2023
ReagentX added a commit that referenced this issue Nov 29, 2023
@ReagentX ReagentX self-assigned this Nov 29, 2023
@ReagentX ReagentX moved this to In Progress in 1.8: Velvet Ash Nov 29, 2023
ReagentX added a commit that referenced this issue Nov 30, 2023
@ReagentX ReagentX mentioned this issue Nov 30, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in 1.8: Velvet Ash Nov 30, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
crate: cli Related to the CLI crate enhancement Requires updating an existing feature exporter Related to exporter processes html Related to HTML Export
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant