Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

iMessages sent to someone who's connected via satellite are exported and rendered incorrectly #404

Closed
nagya opened this issue Dec 16, 2024 · 1 comment · Fixed by #409
Closed

iMessages sent to someone who's connected via satellite are exported and rendered incorrectly #404

nagya opened this issue Dec 16, 2024 · 1 comment · Fixed by #409
Assignees
@ReagentX
Labels
bug Something isn't working crate: cli Related to the CLI crate crate: database Related to the database crate html Related to HTML Export

Comments

@nagya
Copy link

nagya commented Dec 16, 2024

Such messages are exported like this:

<div class="sent Other("iMessageLite")">

which is not valid HTML, and is rendered as blank (two messages in this screenshot; the date is partially selected to show the text is there, but invisible):

iMessageLite

Observed in version 2.2.1.

Similar to #361. Ideally the fix wouldn't just special iMessageLite as #363 did for RCS, but also ensure that unknown service IDs are still exported as valid HTML, and they render in some default color, not invisible.
@ReagentX ReagentX self-assigned this Dec 16, 2024
@ReagentX ReagentX added bug Something isn't working crate: cli Related to the CLI crate html Related to HTML Export crate: database Related to the database crate labels Dec 16, 2024
@ReagentX
Copy link
Owner

Thanks for the report; should be a simple fix.

ReagentX added a commit that referenced this issue Dec 17, 2024
@ReagentX
Support Satellite Messages for #404
29e022d
ReagentX added a commit that referenced this issue Dec 17, 2024
@ReagentX
Improve CSS for #404
0b9e5fb
@ReagentX ReagentX mentioned this issue Dec 17, 2024
Merged
@ReagentX ReagentX mentioned this issue Jan 11, 2025
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@ReagentX ReagentX

Labels
bug Something isn't working crate: cli Related to the CLI crate crate: database Related to the database crate html Related to HTML Export
Projects
No open projects
2.3: Whispering Bells
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/cs/satellite message support ReagentX/imessage-exporter
2 participants
@ReagentX @nagya