Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the false negative test result on

favicon.ico
(icon is actually there, test erroneously says that it is not)Explanation:
querySelectorAll
always returnsHTMLElement[]
[]
(empty array)[]
(empty array) is a truthy value, so[] || <second selector>
will just return[]
Solution:
Always execute both selectors, and use their combined result
Bonus:
This will also fix the check of multiple favicon.ico files being present in case they are matched by both selectors:
P.S.: @phbernard Thanks a lot for your work. Have been using RealFaviconGenerator for many years!