Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix:Serializing subreports to JSON only once even if the global report is decorated. #117

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

ehsavoie
Copy link
Collaborator

No description provided.

@jponge
Copy link
Collaborator

jponge commented Jul 21, 2023

@ehsavoie Commits / PR title will have to be fixed

@ehsavoie ehsavoie changed the title Memory fix: Serializing subreports to JSON only once even if the global report is decorated. Jul 21, 2023
@ehsavoie ehsavoie changed the title fix: Serializing subreports to JSON only once even if the global report is decorated. fix:Serializing subreports to JSON only once even if the global report is decorated. Jul 21, 2023
Removing the use of serialize and using serializeRaw instead

Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
Copy link
Collaborator

@jponge jponge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've done a review with @ehsavoie.

Minor fixes to be applied:

  • add a missing comment on the subreport rewrite trick
  • deprecated the String-returning serialize() method

You can then merge @ehsavoie 👍

…t is decorated..

Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
@jponge jponge merged commit cf58b73 into RedHatInsights:main Sep 11, 2023
2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants