-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix/add test record by object #177
Fix/add test record by object #177
Conversation
- run pre-commit checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the confusing diff in one of the commits, the change looks good, thanks a lot for working on it! I'll merge after making that specific diff reviewable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if possible could you pls make this diff reviewable? In this commit c78247e (4th feat: make test_run agnostic of test_work_item_type
) the current diff is entire file newly edited which is confusing.
|
/hold merge for rework on reviewable diff |
13b653c
to
fea942f
Compare
- create_incident_report and generate_description are now methods of TestRun class
fea942f
to
c597fb1
Compare
I cleaned up my history :) |
Great work, I've tested it and it pass my local test without regression. For test local, after create a dummy project and prepared a Thanks for working on this. |
Hi there!
This PR is addresses #175.
I refactored the functions
create_incident_report
andgenerate_description
to methods of the classTestRun
.In those two methods, I circumnavigate the usage of
TestCase
by using the project's predefined test case work item (member ofproject.get_tests_configuration()
).Should also this work item type not exist, I use the base class
_WorkItem
.I have tested this exploratively on my side, but I could not figure out how to run the unit tests. Can I do that at all?