-
Notifications
You must be signed in to change notification settings - Fork 106
Jobs on GPU #230
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Jobs on GPU #230
Conversation
46366ff
to
1073b8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Now that we know this works, we should indeed consider moving the installation of deps to system_setup.py
to get non-dockerized setups for free and for consistency with the rest of the configurations.
@lantiga @rafie I agree with you on moving the dependency installations to |
@lantiga @rafie |
@hhsecond Thank you Sherin, great job. Given the costs associated with building on GPU, it's really important we don't waste precious compute minutes building. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
(@hhsecond please address Rafi’s comments before merging) |
Hey @hhsecond, are we good to go? |
I am not using any of the existing build utilities such as system-setup.py since relying on a file inside the repo trigger rebuilding of that layer on each push which is time-consuming. We need to iterate over this and other build processes to unify the build processes and to do the packaging and release of GPU docker image etc
Also, because of the
allow growth
feature in TF, the test cases on GPU takes a lot of time now