Add support for batching #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lantiga
force-pushed
the
batching
branch
3 times, most recently
from
0aaccda to
7893e65
Compare
lantiga
requested review from
filipecosta90,
hhsecond,
MeirShpilraien and
K-Jo
and removed request for
filipecosta90
|
Phew, so it looks like I finally finished this one - it took a while. It's ready for review, I'm available for clarifications. |
filipecosta90
requested changes
Feb 2, 2020
|
@lantiga lgtm. Really minor comments but since we're with the hands on the code we migh as well change it :) |
Add support for inspection and eviction to queue Mock run info batching Mock run info batching Make TF tests work Add batching for ONNX and ONNX-ML Fix torch API, still WIP Fix torch backend Fixes after rebasing Add auto-batching to TFLite backend Fix from rebase Add batching args to command and change API accordingly Add batching heuristics [WIP] Fix TFLite test by accessing first tensor in first batch safely Temporarily comment out wrong_bg test check Implement batching heuristics Introduce autobatch tests, tflite still fails Fix segfault when error was generated from the backend Fix tflite autobatch test Updated documentation with auto batching Remove stale comments Avoid making extra copies of inputs and outputs when batch count is 1
lantiga
added a commit
that referenced
this pull request
Feb 15, 2020
lantiga
added a commit
that referenced
this pull request
May 6, 2020
Add support for batching (#241) * Add support for automated batching Add support for inspection and eviction to queue Mock run info batching Mock run info batching Make TF tests work Add batching for ONNX and ONNX-ML Fix torch API, still WIP Fix torch backend Fixes after rebasing Add auto-batching to TFLite backend Fix from rebase Add batching args to command and change API accordingly Add batching heuristics [WIP] Fix TFLite test by accessing first tensor in first batch safely Temporarily comment out wrong_bg test check Implement batching heuristics Introduce autobatch tests, tflite still fails Fix segfault when error was generated from the backend Fix tflite autobatch test Updated documentation with auto batching Remove stale comments Avoid making extra copies of inputs and outputs when batch count is 1 * Address review comments re const-correctness
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #67
ONNXbatching supportTFbatching supportTORCHbatching supportTFLITEbatching supportMODELSETbatching argument(s)MINBATCHargument toMODELSET, orHOLDargument toMODELRUN; the former could have a use outside testing)[WONTFIX] Update clients
NOTE: we will update clients after this one is merged