[add] tests refactoring per backend #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafie
reviewed
Feb 20, 2020
rafie
reviewed
Feb 20, 2020
rafie
reviewed
Feb 20, 2020
Closed
…sts for ai.info on all backends
…oss all input formats and reply formats
… disconnect during work on background thread)
…del tests into normal and error behaviour handling -- prioritize leaks
17 tasks
rafie
approved these changes
Feb 24, 2020
lantiga
approved these changes
Feb 24, 2020
lantiga
pushed a commit
that referenced
this pull request
May 6, 2020
[add] tests refactoring per backend (#296) * [add] tests refactoring per backend * [add] extended testing * [add] added specific modelget and scriptget tests on slaves. added tests for ai.info on all backends * [fix] disabled SCRIPTGET new test since it's hanging CI ( further investigation tbd ) * [fix] disabled SCRIPTGET new test since it's hanging CI ( further investigation tbd ) * [fix] fixing encoding issue on string comparison * [add] refactored tests_common to test for tensorset and tensorget across all input formats and reply formats * [add] added modelrun scriptrun disconnect test cases (test for client disconnect during work on background thread) * [add] increased the GPU tests timeout since we added more tests * [add] added valgrind options to RLTest. pruned testing. * [add] added valgrind options to RLTest. pruned testing. * [fix] fixed leak on RedisAI_ReplicateTensorSet * [fix] fixed leak on ret->devicestr in RAI_ModelCreateTorch * [fix] skipping modelrun and scriptrun disconnect on gpu test * [add] tests prunning for ci * [fix] fixing gpu tests for CI * [add] hardened ensureSlaveSynced * [fix] fixed Makefile in accordance to PR review, [add] splitted tf model tests into normal and error behaviour handling -- prioritize leaks * Delete MakefileCopy
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lantiga and @rafie this splits the tests per backend and the common ones. It also extends coverage and ensures slave sync when required. The whole purpose is to clean and make the tests clear and remove code duplicates
leak fixes: