Skip to content

Fixes AI.MODELGET to return INPUTS,OUTPUTS, BATCHSIZE, and MINBATCHSIZE #384

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
May 25, 2020

Conversation

filipecosta90
Copy link
Collaborator

fixes #378 and updates docs accordingly. This should not break any client (if it does then we need to adjust the clients not to be so restrictive for future changes)

@filipecosta90 filipecosta90 requested a review from gkorland May 25, 2020 10:02
lantiga
lantiga previously approved these changes May 25, 2020
Copy link
Contributor

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #384 into master will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
+ Coverage   72.39%   72.48%   +0.08%     
==========================================
  Files          21       21              
  Lines        4336     4350      +14     
==========================================
+ Hits         3139     3153      +14     
  Misses       1197     1197              
Impacted Files Coverage Δ
src/redisai.c 78.91% <100.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 439f956...74bddac. Read the comment docs.

@filipecosta90 filipecosta90 requested a review from lantiga May 25, 2020 11:37
@filipecosta90
Copy link
Collaborator Author

LGTM

@lantiga already merged master on it. Can you check it after the gpu build passes?

@filipecosta90 filipecosta90 merged commit a2be098 into master May 25, 2020
@filipecosta90 filipecosta90 deleted the modelget.fix branch May 25, 2020 11:59
@filipecosta90 filipecosta90 mentioned this pull request May 27, 2020
@filipecosta90 filipecosta90 mentioned this pull request Aug 20, 2020
5 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI.MODELGET needs to return INPUTS,OUTPUTS, BATCHSIZE, and MINBATCHSIZE
2 participants