-
Notifications
You must be signed in to change notification settings - Fork 106
expose model inputs and outputs with respect to model definition #552
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #552 +/- ##
==========================================
- Coverage 72.57% 72.14% -0.43%
==========================================
Files 35 35
Lines 5626 5824 +198
==========================================
+ Hits 4083 4202 +119
- Misses 1543 1622 +79
Continue to review full report at Codecov.
|
src/command_parser.c
Outdated
@@ -71,15 +71,13 @@ static int _ModelRunCommand_ParseArgs(RedisModuleCtx *ctx, RedisModuleString **a | |||
} | |||
if ((*model)->inputs && (*model)->ninputs != ninputs) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the condition (*model)->inputs is still needed? The inputs and outputs arrays should be allocated in all backends now (not only in TF) right?
Looks great, the failing tests should be just a matter of updating the tests themselves. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closes #529