Turn dag local context dict into array #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In TF: verify that model inputs names correspond to model inputs ops (and not just for any op)
…tensors (instead of the DagLocalContext dict). Every op holds the indices of its input and output tensors, and uses this array to load and store them in turn.
Codecov Report
@@ Coverage Diff @@
## master #582 +/- ##
==========================================
+ Coverage 74.27% 74.28% +0.01%
==========================================
Files 39 39
Lines 6083 5997 -86
==========================================
- Hits 4518 4455 -63
+ Misses 1565 1542 -23
Continue to review full report at Codecov.
|
- Save the indices of the tensors to persist as values in persistTensors dict, and release TensorsNamesToIndices before DAG run.
lantiga
previously approved these changes
Feb 1, 2021
DvirDukhan
reviewed
Feb 2, 2021
src/DAG/dag.h
Outdated
| * @param index The index of the tensor in the Dag shared array to return | ||
| * @return The tensor of the given index (NULL is returned if this tensor hasn't been realized yet) | ||
| */ | ||
| RAI_Tensor *Dag_GetInternalTensor(RedisAI_RunInfo *rinfo, size_t index); |
There was a problem hiding this comment.
Suggested change
| RAI_Tensor *Dag_GetInternalTensor(RedisAI_RunInfo *rinfo, size_t index); | |
| RAI_Tensor *Dag_GetTensorFromGlobalCtx(RedisAI_RunInfo *rinfo, size_t index); |
src/DAG/dag.h
Outdated
| * @param index The index to put in the given tensor in the Dag shared array. | ||
| * @param t The tensor to shallow copy and store in the given index. | ||
| */ | ||
| void Dag_SetInternalTensor(RedisAI_RunInfo *rinfo, size_t index, RAI_Tensor *t); |
There was a problem hiding this comment.
Suggested change
| void Dag_SetInternalTensor(RedisAI_RunInfo *rinfo, size_t index, RAI_Tensor *t); | |
| void Dag_SetTensorInGlobalCtx(RedisAI_RunInfo *rinfo, size_t index, RAI_Tensor *t); |
DvirDukhan
approved these changes
Feb 2, 2021
DvirDukhan
pushed a commit
that referenced
this pull request
Feb 3, 2021
Turn dag local context dict into array
Closed
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a shared array in DAG runInfo that stores DAG intermediate tensors (instead of the DagLocalContext dict). Every DAG operation holds the indices of its input and output tensors, and uses this array to load and store them in turn.