Skip to content

Install redis-gears from S3 as part of module deps, and test AI-Gears LLAPI. #584

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 11 commits into from
Feb 22, 2021

Conversation

alonre24
Copy link
Collaborator

@alonre24 alonre24 commented Feb 2, 2021

Download RedisGears from S3 as part of flow tests dependencies, and add tests that uses gears through the LLAPI to test suit.

@alonre24 alonre24 self-assigned this Feb 2, 2021
- Install gears from flow test (instead of deps)
- Add gears suppressions to valgrind.sup
@alonre24 alonre24 force-pushed the Add_tests_with_gears_to_CI branch from b210053 to a197b9f Compare February 2, 2021 17:31
@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #584 (b3cb0d7) into master (acea0b8) will decrease coverage by 0.39%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #584      +/-   ##
==========================================
- Coverage   74.79%   74.39%   -0.40%     
==========================================
  Files          39       39              
  Lines        6062     6062              
==========================================
- Hits         4534     4510      -24     
- Misses       1528     1552      +24     
Impacted Files Coverage Δ
src/backends/onnxruntime.c 61.02% <0.00%> (-6.73%) ⬇️
src/tensor.c 76.77% <0.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acea0b8...b3cb0d7. Read the comment docs.

Copy link

@tata406 tata406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Su

tata406
tata406 previously approved these changes Feb 17, 2021
DvirDukhan
DvirDukhan previously approved these changes Feb 22, 2021
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think about quoting all shall variables in Install_RedisGears.sh.

This StackOverflow has a good discussion of the security implications as to why.

https://unix.stackexchange.com/questions/171346/security-implications-of-forgetting-to-quote-a-variable-in-bash-posix-shells

@CLAassistant
Copy link

CLAassistant commented Feb 22, 2021

CLA assistant check
All committers have signed the CLA.

@alonre24 alonre24 merged commit 593d495 into master Feb 22, 2021
@alonre24 alonre24 deleted the Add_tests_with_gears_to_CI branch February 22, 2021 11:40
alonre24 added a commit that referenced this pull request Mar 16, 2021
Install redis-gears from S3 as part of module deps, and test AI-Gears LLAPI.
@chayim chayim mentioned this pull request Jul 22, 2021
@chayim chayim mentioned this pull request Nov 7, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants