-
Notifications
You must be signed in to change notification settings - Fork 106
Install redis-gears from S3 as part of module deps, and test AI-Gears LLAPI. #584
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
- Install gears from flow test (instead of deps) - Add gears suppressions to valgrind.sup
b210053
to
a197b9f
Compare
Codecov Report
@@ Coverage Diff @@
## master #584 +/- ##
==========================================
- Coverage 74.79% 74.39% -0.40%
==========================================
Files 39 39
Lines 6062 6062
==========================================
- Hits 4534 4510 -24
- Misses 1528 1552 +24
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Su
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think about quoting all shall variables in Install_RedisGears.sh.
This StackOverflow has a good discussion of the security implications as to why.
Install redis-gears from S3 as part of module deps, and test AI-Gears LLAPI.
Download RedisGears from S3 as part of flow tests dependencies, and add tests that uses gears through the LLAPI to test suit.