-
Notifications
You must be signed in to change notification settings - Fork 106
adding lite to the release automation #773
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Added to the nightly automation area of CircleCI, in case it gets used in the future
Codecov Report
@@ Coverage Diff @@
## master #773 +/- ##
==========================================
+ Coverage 79.15% 79.17% +0.02%
==========================================
Files 49 49
Lines 7651 7651
==========================================
+ Hits 6056 6058 +2
+ Misses 1595 1593 -2
Continue to review full report at Codecov.
|
Any AI variant can now run against a specific version of redis, or versions, as defined in its own file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments
tests/qa/RS_VERSIONS-lite
Outdated
@@ -0,0 +1,2 @@ | |||
6.0.12-58 | |||
100.0.0-2400 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be 100.0.0-2440 isn't it? @tomerhekredis ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On non-lite @tomerhekredis said we wanted 100.0.0-2400 on on RS_VERSIONS- the 6.0x thing. It's worth noting we can now basically do anything here by adding variants and files. @tomerhekredis ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it should be 2440 in all RS_VERSIONS files
tests/qa/RS_VERSIONS
Outdated
@@ -1,2 +1 @@ | |||
6.0.12-58 | |||
100.0.0-2400 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be 100.0.0-2440 isn't it? @tomerhekredis ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above.
@@ -89,10 +90,12 @@ run_test() { | |||
} | |||
|
|||
rc=0 | |||
# By default we use RS_VERSIONS, but with variants they may need to specify their own redis verisons, hence this file | |||
VERSIONFILE=${HERE}/RS_VERSIONS${VARIANT} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We send VARIANT=lite
from circleci.yaml
but the file name is RS_VERSIONS-lite
(with a dash) - is that a problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CircleCI passes in VARIANT=-lite, which we use to build the file. This was validated with @tomerhekredis
Co-authored-by: tomerhekredis <72793005+tomerhekredis@users.noreply.github.com>
Also added in to the nightly automation area of CircleCI, in case it gets used in the future