Skip to content

adding lite to the release automation #773

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Jun 1, 2021
Merged

adding lite to the release automation #773

merged 4 commits into from
Jun 1, 2021

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Jun 1, 2021

Also added in to the nightly automation area of CircleCI, in case it gets used in the future

Added to the nightly automation area of CircleCI, in case it gets used in the future
@chayim chayim requested review from alonre24 and DvirDukhan June 1, 2021 08:50
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #773 (3736f7b) into master (6987193) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 3736f7b differs from pull request most recent head 916d6b5. Consider uploading reports for the commit 916d6b5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #773      +/-   ##
==========================================
+ Coverage   79.15%   79.17%   +0.02%     
==========================================
  Files          49       49              
  Lines        7651     7651              
==========================================
+ Hits         6056     6058       +2     
+ Misses       1595     1593       -2     
Impacted Files Coverage Δ
src/execution/execution_contexts/modelRun_ctx.c 80.55% <0.00%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 865661d...916d6b5. Read the comment docs.

Any AI variant can now run against a specific version of redis, or versions, as defined in its own file
Copy link
Collaborator

@alonre24 alonre24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

@@ -0,0 +1,2 @@
6.0.12-58
100.0.0-2400
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 100.0.0-2440 isn't it? @tomerhekredis ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On non-lite @tomerhekredis said we wanted 100.0.0-2400 on on RS_VERSIONS- the 6.0x thing. It's worth noting we can now basically do anything here by adding variants and files. @tomerhekredis ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it should be 2440 in all RS_VERSIONS files

@@ -1,2 +1 @@
6.0.12-58
100.0.0-2400
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 100.0.0-2440 isn't it? @tomerhekredis ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above.

@@ -89,10 +90,12 @@ run_test() {
}

rc=0
# By default we use RS_VERSIONS, but with variants they may need to specify their own redis verisons, hence this file
VERSIONFILE=${HERE}/RS_VERSIONS${VARIANT}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We send VARIANT=lite from circleci.yaml but the file name is RS_VERSIONS-lite (with a dash) - is that a problem?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CircleCI passes in VARIANT=-lite, which we use to build the file. This was validated with @tomerhekredis

@chayim chayim merged commit d42ad15 into master Jun 1, 2021
@chayim chayim deleted the ck-tomer-testlite branch June 1, 2021 10:02
chayim added a commit that referenced this pull request Jun 1, 2021
Co-authored-by: tomerhekredis <72793005+tomerhekredis@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants