Onnx kill switch #779
Merged
Onnx kill switch #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… multiple devices). Tests pass (new feature hasn't tested yet)
…w device is introduced and use rwlock to synchronise.
…'t overflows than the tensor type in TENSORSET.
Codecov Report
@@ Coverage Diff @@
## master #779 +/- ##
==========================================
+ Coverage 79.22% 79.99% +0.77%
==========================================
Files 50 52 +2
Lines 7662 7767 +105
==========================================
+ Hits 6070 6213 +143
+ Misses 1592 1554 -38
Continue to review full report at Codecov.
|
DvirDukhan
requested changes
Jun 10, 2021
Comment on lines
+29
to
+36
| if (strcasecmp((key), "TF") == 0) { | ||
| ret = RAI_LoadBackend(ctx, RAI_BACKEND_TENSORFLOW, (val)); | ||
| } else if (strcasecmp((key), "TFLITE") == 0) { | ||
| ret = RAI_LoadBackend(ctx, RAI_BACKEND_TFLITE, (val)); | ||
| } else if (strcasecmp((key), "TORCH") == 0) { | ||
| ret = RAI_LoadBackend(ctx, RAI_BACKEND_TORCH, (val)); | ||
| } else if (strcasecmp((key), "ONNX") == 0) { | ||
| ret = RAI_LoadBackend(ctx, RAI_BACKEND_ONNXRUNTIME, (val)); |
There was a problem hiding this comment.
what is this loading section here?
There was a problem hiding this comment.
This is called from ai.config LOADBACKEND <backend> <backend_path> command.
…aces that are affected)
…into ONNX_kill_switch
…om backend len (supported only for onnx now) in INFO MODULES command.
DvirDukhan
reviewed
Jun 12, 2021
DvirDukhan
reviewed
Jun 12, 2021
- Add a state flag to every entry in the onnx run sessions array and update it atomically, to avoid situations where main threads and bg thread both access the runOptions field. - Refactor the info_modules section, and change AI.INFO command so it must receive a module/script key. The other info will be accessible as part of the info modules command.
…eated from start, number of threads in this case should be larger.
DvirDukhan
reviewed
Jun 14, 2021
… instance). test info command with AI fields
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the "ONNX kill switch" - a mechanism for terminating onnx sessions whose runtime exceeds a certain threshold. It is done by registering a callback to Redis cron event loop (runs by default every 100 ms) upon loading onnx backend. This callback will use the "kill" API that ONNX has for every session that its runtime exceeds the timeout. Note that: