Skip to content

remove duplicate symbols for real gcc10 compatibility #825

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DvirDukhan
Copy link
Collaborator

This PR adds -fcommon to gcc compile flag, to avoid errors on multiple definitions of the same variable.
see https://gcc.gnu.org/gcc-10/porting_to.html
however, this is just a workaround and we should have a proper, in-depth solution

@DvirDukhan DvirDukhan requested review from chayim and rafie July 26, 2021 11:39
rafie
rafie previously approved these changes Jul 26, 2021
chayim
chayim previously approved these changes Jul 26, 2021
@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #825 (ff9482b) into master (8e40eaf) will increase coverage by 0.04%.
The diff coverage is 93.75%.

❗ Current head ff9482b differs from pull request most recent head aadc5e9. Consider uploading reports for the commit aadc5e9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #825      +/-   ##
==========================================
+ Coverage   79.91%   79.96%   +0.04%     
==========================================
  Files          53       53              
  Lines        8044     8019      -25     
==========================================
- Hits         6428     6412      -16     
+ Misses       1616     1607       -9     
Impacted Files Coverage Δ
src/execution/DAG/dag.c 91.73% <88.88%> (+1.47%) ⬆️
src/redisai.c 86.99% <95.23%> (+1.07%) ⬆️
src/execution/parsing/dag_parser.c 96.01% <100.00%> (+0.01%) ⬆️
src/execution/parsing/deprecated.c 79.70% <100.00%> (-1.69%) ⬇️
...ckends/libtorch_c/torch_extensions/torch_redis.cpp 94.73% <0.00%> (-0.22%) ⬇️
src/backends/libtorch_c/torch_c.cpp 63.94% <0.00%> (-0.18%) ⬇️
src/backends/torch.c 84.19% <0.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db9857c...aadc5e9. Read the comment docs.

@Spartee Spartee mentioned this pull request Jul 27, 2021
@DvirDukhan DvirDukhan dismissed stale reviews from chayim and rafie via aadc5e9 August 1, 2021 09:19
@DvirDukhan DvirDukhan closed this Oct 24, 2021
@DvirDukhan DvirDukhan reopened this Oct 24, 2021
@DvirDukhan DvirDukhan marked this pull request as draft October 24, 2021 06:38
@DvirDukhan DvirDukhan changed the title added -fcommon to compile flag for gcc10 support remove duplicate symbols for real gcc10 compatibility Oct 24, 2021
@CLAassistant
Copy link

CLAassistant commented Sep 22, 2022

CLA assistant check
All committers have signed the CLA.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants