Skip to content

Remove deprecation warning #829

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Aug 15, 2021
Merged

Remove deprecation warning #829

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d17b570
Remove the deprecation warning logging in MODELRUN command
alonre24 Aug 12, 2021
2d40882
Remove the deprecation warning logging for all deprecated commands
alonre24 Aug 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 1 addition & 28 deletions src/redisai.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,9 +137,6 @@ int RedisAI_TensorGet_RedisCommand(RedisModuleCtx *ctx, RedisModuleString **argv
*/
int RedisAI_ModelSet_RedisCommand(RedisModuleCtx *ctx, RedisModuleString **argv, int argc) {

RedisModule_Log(ctx, "warning",
"AI.MODELSET command is deprecated and will"
" not be available in future version, you can use AI.MODELSTORE instead");
return ModelSetCommand(ctx, argv, argc);
}

Expand Down Expand Up @@ -565,16 +562,9 @@ int RedisAI_ModelScan_RedisCommand(RedisModuleCtx *ctx, RedisModuleString **argv
*/
int RedisAI_ModelRun_RedisCommand(RedisModuleCtx *ctx, RedisModuleString **argv, int argc) {
if (IsEnterprise()) {
RedisModule_Log(ctx, "warning",
"AI.MODELRUN command is deprecated and cannot be used in "
"enterprise cluster, use AI.MODELEXECUTE instead");
return RedisModule_ReplyWithError(
ctx, "ERR AI.MODELRUN command is deprecated and cannot be used in "
"enterprise cluster, use AI.MODELEXECUTE instead");
} else {
RedisModule_Log(ctx, "warning",
"AI.MODELRUN command is deprecated and will"
" not be available in future version, you can use AI.MODELEXECUTE instead");
}
if (RedisModule_IsKeysPositionRequest(ctx)) {
return RedisAI_ModelRun_IsKeysPositionRequest_ReportKeys(ctx, argv, argc);
Expand Down Expand Up @@ -711,9 +701,6 @@ int RedisAI_ScriptDel_RedisCommand(RedisModuleCtx *ctx, RedisModuleString **argv
* AI.SCRIPTSET script_key device [TAG tag] SOURCE script_source
*/
int RedisAI_ScriptSet_RedisCommand(RedisModuleCtx *ctx, RedisModuleString **argv, int argc) {
RedisModule_Log(ctx, "warning",
"AI.SCRIPTSET command is deprecated and will"
" not be available in future version, you can use AI.SCRIPTSTORE instead");
return ScriptSetCommand(ctx, argv, argc);
}

Expand Down Expand Up @@ -960,16 +947,9 @@ int RedisAI_Config_RedisCommand(RedisModuleCtx *ctx, RedisModuleString **argv, i
*/
int RedisAI_DagRun_RedisCommand(RedisModuleCtx *ctx, RedisModuleString **argv, int argc) {
if (IsEnterprise()) {
RedisModule_Log(ctx, "warning",
"AI.DAGRUN command is deprecated and cannot be used in "
"enterprise cluster, use AI.DAGEXECUTE instead");
return RedisModule_ReplyWithError(
ctx, "ERR AI.DAGRUN command is deprecated and cannot be used in "
"enterprise cluster, use AI.DAGEXECUTE instead");
} else {
RedisModule_Log(ctx, "warning",
"AI.DAGRUN command is deprecated and will"
" not be available in future version, you can use AI.DAGEXECUTE instead");
}
if (RedisModule_IsKeysPositionRequest(ctx)) {
return RedisAI_DagExecute_IsKeysPositionRequest_ReportKeys(ctx, argv, argc);
Expand Down Expand Up @@ -1005,16 +985,9 @@ int RedisAI_DagExecute_RedisCommand(RedisModuleCtx *ctx, RedisModuleString **arg
*/
int RedisAI_DagRunRO_RedisCommand(RedisModuleCtx *ctx, RedisModuleString **argv, int argc) {
if (IsEnterprise()) {
RedisModule_Log(ctx, "warning",
"AI.DAGRUN_RO command is deprecated and cannot be used in "
"enterprise cluster, use AI.DAGEXECUTE_RO instead");
return RedisModule_ReplyWithError(
ctx, "ERR AI.DAGRUN_RO command is deprecated and cannot be used in "
"enterprise cluster, use AI.DAGEXECUTE instead");
} else {
RedisModule_Log(ctx, "warning",
"AI.DAGRUN_RO command is deprecated and will"
" not be available in future version, you can use AI.DAGEXECUTE instead");
"enterprise cluster, use AI.DAGEXECUTE_RO instead");
}
if (RedisModule_IsKeysPositionRequest(ctx)) {
return RedisAI_DagExecute_IsKeysPositionRequest_ReportKeys(ctx, argv, argc);
Expand Down