Skip to content

Add support for AI._MODELSCAN AI._SCRIPTSCAN #13

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dengliming
Copy link
Contributor

No description provided.

@filipecosta90
Copy link
Collaborator

hi there @dengliming, given that the MODELSCAN and SCRIPTSCAN are still experimental and will probably suffer changes ( potential breaking ones ) we were holding on supporting them on the clients ( we needed them supported on the python client for 3rd party integrations ) but I would say not to do so (for now) on the other clients ( java, go ).
Lets keep this PR open but not merge yet and wait for both commands to mature ok? =)

@dengliming
Copy link
Contributor Author

Got it. Thanks.

@dengliming
Copy link
Contributor Author

dengliming commented May 11, 2020

@filipecosta90 The command args [TAG tag] on AI.SCRIPTSET is experimental too? If so, should i close #15 and #14 ?

@filipecosta90
Copy link
Collaborator

@filipecosta90 The command args [TAG tag] on AI.SCRIPTSET is experimental too? If so, should i close #15 and #14 ?

hi there @dengliming . No :) the TAG's are there to stay. Do you want to take it?

@dengliming
Copy link
Contributor Author

I will submit a PR for it recently ^_^

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants