Skip to content

New version #27

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 8 commits into from
Dec 6, 2019
Merged

New version #27

merged 8 commits into from
Dec 6, 2019

Conversation

hhsecond
Copy link
Contributor

@hhsecond hhsecond added the workinprogress Don't merge; Work in Progress label Nov 29, 2019
@lgtm-com
Copy link

lgtm-com bot commented Nov 29, 2019

This pull request introduces 3 alerts when merging e37a5d3 into 94d0499 - view on LGTM.com

new alerts:

  • 2 for Wrong name for an argument in a call
  • 1 for Unused import

@codecov
Copy link

codecov bot commented Nov 30, 2019

Codecov Report

Merging #27 into master will increase coverage by 2.73%.
The diff coverage is 97.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
+ Coverage   93.63%   96.37%   +2.73%     
==========================================
  Files           7        8       +1     
  Lines         283      276       -7     
==========================================
+ Hits          265      266       +1     
+ Misses         18       10       -8
Impacted Files Coverage Δ
redisai/__init__.py 100% <ø> (ø) ⬆️
redisai/constants.py 100% <100%> (ø) ⬆️
redisai/client.py 95.71% <100%> (-0.07%) ⬇️
redisai/version.py 100% <100%> (ø) ⬆️
redisai/containers.py 100% <100%> (ø)
redisai/convert.py 92.59% <92.59%> (ø)
test/test.py 99.21% <98.5%> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94d0499...821244b. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Nov 30, 2019

This pull request introduces 4 alerts when merging 8e0d8b0 into 94d0499 - view on LGTM.com

new alerts:

  • 2 for Wrong name for an argument in a call
  • 2 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Nov 30, 2019

This pull request fixes 2 alerts when merging bd049f1 into 94d0499 - view on LGTM.com

fixed alerts:

  • 2 for Wrong name for an argument in a call

@lgtm-com
Copy link

lgtm-com bot commented Nov 30, 2019

This pull request fixes 2 alerts when merging 8a9b28a into 94d0499 - view on LGTM.com

fixed alerts:

  • 2 for Wrong name for an argument in a call

@hhsecond hhsecond removed the workinprogress Don't merge; Work in Progress label Nov 30, 2019
Copy link
Contributor

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, only two minor changes.

@lgtm-com
Copy link

lgtm-com bot commented Dec 5, 2019

This pull request fixes 2 alerts when merging 821244b into 94d0499 - view on LGTM.com

fixed alerts:

  • 2 for Wrong name for an argument in a call

Copy link
Contributor

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lantiga lantiga merged commit 18837ea into master Dec 6, 2019
@hhsecond hhsecond deleted the cleanup branch December 6, 2019 08:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants