Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

K8s: revise openshift cli getting started #1675

Merged
merged 10 commits into from
Dec 15, 2021
Merged

K8s: revise openshift cli getting started #1675

merged 10 commits into from
Dec 15, 2021

Conversation

kaitlynmichael
Copy link
Contributor

@kaitlynmichael kaitlynmichael commented Nov 23, 2021

@kaitlynmichael kaitlynmichael added in progress Changes are in progress K8s Kubernetes labels Nov 23, 2021
@kaitlynmichael kaitlynmichael self-assigned this Nov 23, 2021
@kaitlynmichael kaitlynmichael removed the in progress Changes are in progress label Dec 6, 2021
@kaitlynmichael
Copy link
Contributor Author

Copy link
Contributor

@lanceleonard lanceleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though a couple of things need to be tweaked.

Co-authored-by: Lance Leonard <lanceleonard@users.noreply.github.com>
Copy link
Collaborator

@rrelledge rrelledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I left a couple of small suggestions.

@kaitlynmichael kaitlynmichael requested a review from bascar December 6, 2021 18:45
Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com>
Copy link
Contributor

@lanceleonard lanceleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaitlynmichael kaitlynmichael merged commit 419979e into master Dec 15, 2021
@kaitlynmichael kaitlynmichael deleted the jira-doc-870 branch December 15, 2021 18:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
K8s Kubernetes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants