feat: support const and examples #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RomanHotsiy Any chance to get this merged? |
|
Sorry, super busy. I will check this on weekends |
|
Fantastic — this would really help us! |
|
@RomanHotsiy Have you been able to check this out? |
|
LGTM 👍 Thanks. |
|
fyi: already released |
|
Oh fantastic, I'll try this out! |
|
@RomanHotsiy I can't find it on npm 🤔 |
|
Whoops, looks like I have to update npm key on Travis. Deployed manually. Should be on npm already! |
RomanHotsiy
pushed a commit
that referenced
this pull request
May 25, 2021
* feat: add more formats * chore: pr feedback
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
const was added in JSON schema draft 6: https://json-schema.org/understanding-json-schema/reference/generic.html#constant-values
I see that "example" is supported on the OpenAPI level but it should also be supported in the JSON schema: https://json-schema.org/understanding-json-schema/reference/generic.html#annotations