CMake selective build improvements #637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can check for missing code with selective compilation with env LDFLAGS='-Wl,-z,defs' cmake -DBUILD_SHARED_LIBS=ON ../lapack |
Codecov Report
@@ Coverage Diff @@
## master #637 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 1894 1894
Lines 184034 184021 -13
=======================================
+ Misses 184034 184021 -13
Continue to review full report at Codecov.
|
If the user requests LAPACKE to be built for a certain arithmetic (e.g., real double-precision), check if the LAPACK library contains code for the requested arithmetic.
Fix linking when only a subset of the available arithmetic (e.g., only complex double-precision arithmetic) is built.
christoph-conrads
force-pushed
the
632-lapack_h-only-installed-in-LAPACKE-builds
branch
from
ac6679e to
ca0b206
Compare
weslleyspereira
approved these changes
Feb 15, 2022
There was a problem hiding this comment.
Hi @christoph-conrads. Thanks for the improvements!
I think it is helpful to install lapack.h even when LAPACKE is off.
2 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This merge request
lapack.heven when LAPACKE is not built,LAPACKE_BUILD_SINGLE=ONimpliesBUILD_SINGLE=ON).Checklist