Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[REG-2075] Add resource path to large segment cards #332

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

addisonbgross
Copy link
Contributor

image

What has been done

  • Added a resource path text component to the large Segment Cards
    • This will show beneath the card's name field. If the name field is missing, we will use the resource path in its stead
  • Added the resource path text to the dragging card prefab
  • Increased the height of the potential drop spot prefab

LOOM (It cuts before I'm done talking, but its ok)

https://www.loom.com/share/66adb820a05b4fbe88991f499813945a

@addisonbgross addisonbgross changed the title feat: add resource path to large segment cards [REG-2075] Add resource path to large segment cards Oct 7, 2024
@addisonbgross addisonbgross requested review from batu and abeizer October 7, 2024 23:26
Copy link
Collaborator

@nAmKcAz nAmKcAz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I feel like the path on the segment cards needs to move down about 3-5 pixels in the Y coordinate. The text is a bit too tightly spaced to the name for me

@addisonbgross
Copy link
Contributor Author

@RG-nAmKcAz good thinking. I did a slight adjustment to both the SequenceCard and SegmentCardLarge prefabs. I also moved that red, recording dot on Sequence cards so that it's behind the card's name. I noticed that it could block the name text a bit

image
image

@addisonbgross addisonbgross merged commit ee73652 into main Oct 8, 2024
2 checks passed
@addisonbgross addisonbgross deleted the addison/reg-2075 branch October 8, 2024 18:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants