Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[REG-2105] Allow absolute paths to be used in segment and sequence loading #333

Merged
merged 4 commits into from
Oct 16, 2024
Merged

[REG-2105] Allow absolute paths to be used in segment and sequence loading #333

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
948e9e4
Allow absolute paths to be used in segment and sequence loading
vontell Oct 9, 2024
a038e25
Catch absolute paths when using the CLI args
vontell Oct 16, 2024
864f982
Oops
vontell Oct 16, 2024
63e2416
Introduce new quit error code
vontell Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/gg.regression.unity.bots/Runtime/Scripts/StateRecorder/BotSegments/Models/BotSequence.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,6 @@ public static (string, string, BotSequence) LoadSequenceJsonFromPath(string path
return (null, null, null);
}

if (path.StartsWith('/') || path.StartsWith('\\'))
{
throw new Exception("Invalid path. Path must be relative, not absolute in order to support editor vs production runtimes interchangeably.");
}

path = path.Replace('\\', '/');

(string, string, string) sequenceJson;
Expand Down Expand Up @@ -144,10 +139,6 @@ private static object ParseSegmentOrListJson(string resourcePath, string fileDat
*/
public static (string, string, object) LoadBotSegmentOrBotSegmentListFromPath(string path)
{
if (path.StartsWith('/') || path.StartsWith('\\'))
{
throw new Exception("Invalid path. Path must be relative, not absolute, in order to support editor vs production runtimes interchangeably.");
}

path = path.Replace('\\', '/');

Expand Down
Loading