allow for garbage collection algo preference #40
Conversation
|
Hey! Thanks for the contribution! That way it is documented, and available via all deployment methods. |
|
Updated with both fixed docs in run_server, as well as docker-compose and README updates @Renegade-Master |
|
Thank you for adding the extra bits. Would you mind changing the line in .github/workflows/docker-build.yml#L265 according to the following diff? - check_for_config "znet: Java_zombie_core_znet_SteamUtils_n_1Shutdown"
+ check_for_config "ZNet: SZombienet -> SSteamSDK: LogOff"Should be good to go after that. |
|
Actions updated, sorry for the delay on this one! |
|
Thanks for updating that! I would do it myself, but I have too many other things to be doing at the moment 😅 And it looks like the new versions of Project Zomboid have changed some configuration things.
That Port was definitely set, so something must have changed about the ini file structure.
I will try to take a look at this tomorrow. It should just be a case of figuring out what the new name for the main Port is. |
https://theindiestone.com/forums/index.php?/topic/47417-dedicated-server-on-linux-vps-jre-crashes/ Only way to keep my server stable with 10+ people is to set to G1GC, but there's other java jre gc options Afaik there's only a few java GC's that'd matter. ZGC is usually best, but G1GC can sometimes be more efficient with it's RAM usage. Probably related to something dumb in either my vm configs or otherwise, but seems like an easy change to allow it to be configurable more generally. Maybe just adds tech debt to potential future work to deal with Renegade-Master#38 and Renegade-Master#23 but idk, this is an easy fix for my specific problems. Signed-off-by: Dylan Shepard <dylan@shepard.dev>
Renegade-Master
force-pushed
the
patch-1
branch
from
5130223 to
f1ba1da
Compare
Signed-off-by: Renegade-Master <renegade.master.dev@protonmail.com>
- .github/workflows/docker-build.yml - Add environment configuration for new GC Config option. - Add Test for new configuration option. - README.md - Formatting pass. - docker-compose.yaml - Formatting pass.
|
Hey I've been at Kubecon all week, anything you need from me here? Happy to rebase whatever. |
|
I didn't realise there were two Kubecons per year. I went to the European one 6 months ago 😅 I just need to get this test working for the changed GC. It does the change, my syntax is just wrong for the validation. I couldn't get it last night. |
|
Kudos, SonarCloud Quality Gate passed!
|
https://theindiestone.com/forums/index.php?/topic/47417-dedicated-server-on-linux-vps-jre-crashes/
Only way to keep my server stable with 10+ people is to set to G1GC, but there's other java jre gc options
Afaik there's only a few java GC's that'd matter. ZGC is usually best, but G1GC can sometimes be more efficient with it's RAM usage. Probably related to something dumb in either my vm configs or otherwise, but seems like an easy change to allow it to be configurable more generally.
Maybe just adds tech debt to potential future work to deal with #38 and #23 but idk, this is an easy fix for my specific problems.
Signed-off-by: Dylan Shepard dylan@shepard.dev