Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add presets and calibration related methods, add to docs, add example jsons #74

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

car-haj
Copy link
Contributor

@car-haj car-haj commented Jan 23, 2024

To utilize the PTZ function, especially the presets, it's necessary to 'calibrate' some or at least the E1 Zoom camera to achieve non drifting behaviour when gearing towards stored preset locations. This can be achieved using the newly provided calibration function "perform_calibration" in this commit. Before calibrating, one can check whether the calibration is necessary using the get_ptz_check_state (PtzCheckState 2 being already calibrated). Also add get_ptz_presets function to get information about the currently stored presets. Tested on Reolink E1 Zoom on most recent firmware.

…ation, amend docs, add examples, add E1 Zoom to list of supported cameras
@car-haj car-haj changed the title add presets and calibration related methods, enance docs, add example jsons feat: add presets and calibration related methods, add to docs, add example jsons Jan 23, 2024
Copy link
Member

@Benehiko Benehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks quite good!

I have no way of verifying this, but I don't see a reason not to merge :)

I'll trust that these APIs work correctly

@Benehiko Benehiko merged commit 2eab380 into ReolinkCameraAPI:master Jan 24, 2024
sven337 pushed a commit to sven337/reolinkapipy that referenced this pull request Aug 13, 2024
…xample jsons (ReolinkCameraAPI#74)

add get methods for presets, calibration status and action for calibration, amend docs, add examples, add E1 Zoom to list of supported cameras
sven337 pushed a commit to sven337/reolinkapipy that referenced this pull request Aug 14, 2024
…xample jsons (ReolinkCameraAPI#74)

add get methods for presets, calibration status and action for calibration, amend docs, add examples, add E1 Zoom to list of supported cameras
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants