Additional info on state changes of buttons #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…camera is not opened. This is useful to check, if a camera is opened or closed.
…wheel" and the button id or wheel position is sent in the arguments. This is useful to use one callback for all buttons.
…e. Useful for common callbacks
rethink-imcmahon
changed the title
This was referenced Sep 9, 2015
| @@ -75,7 +75,7 @@ def __init__(self, name): | |||
|
|
|||
| list_svc = rospy.ServiceProxy('/cameras/list', ListCameras) | |||
| rospy.wait_for_service('/cameras/list', timeout=10) | |||
| if not self._id in list_svc().cameras: | |||
| if not self._id in ["left_hand_camera","right_hand_camera","head_camera"]: | |||
There was a problem hiding this comment.
The robot will now list all 3 cameras as services, so I don't see the benefit in hard-coding the camera names here.
There was a problem hiding this comment.
In the old SDK a roservice call /cameras/list listed you all available cameras. In the new version you get exactly the opened cameras which are left_hand_camera and right_hand_camera by default.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DigitalIO and Navigators
This little improvement enables you to see which buttons was pressed in your callback function.
Therefore you need only one callback function for all your buttons.
e.g.:
Camera
The current implementation raises an exception, if the camera is currently closed. I think it is useful in the camera controller to check, if the camera is opened or closed. Also in the past the service call to the camera list yielded all 3 cameras, which is not the case any more. Therefore I recommend to change the condition of the if in the init