New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support async getClientInitialProps w backwards compabitible typing #77

Merged

rrdelaney merged 1 commit into RevereCRE:main from GioLogist:client-side-async

Nov 29, 2022

Contributor

GioLogist commented Nov 29, 2022

Fixes #70

We noticed that WiredComponent.getInitialProps is sync on client and async on server. We would be interested in them being async on either or, since it's technically allowed in Next.JS

As requested, also added backwards compatible typing, so sync and async will continue to work without issue.


          Support async getClientInitialProps w backwards compabitible typing

9bb3dc7

rrdelaney approved these changes

View reviewed changes

Contributor

rrdelaney left a comment

This is great, thank you! Will release as v1.0.1 soon.

rrdelaney merged commit 09b7f53 into RevereCRE:main

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet