-
Notifications
You must be signed in to change notification settings - Fork 223
Rex::Logger improvements #848
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
Conversation
@@ -32,11 +32,10 @@ package Rex::Logger; | |||
|
|||
use strict; | |||
use warnings; | |||
use Exporter::Shiny qw/debug info warn error/; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need Exporter::Shiny
as a new dependency? :)
321ca8a
to
fa5efa8
Compare
|
|
||
sub error { logger( shift, "error" ) } | ||
sub warn { logger( shift, "warn" ) } | ||
sub info { logger( shift, "info" ) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid this breaks existing Rex::Logger::info
calls in the wild, at least when they specified warn
or error
levels :/ Am I missing something? Maybe I'm mistaken, didn't test it yet.
fa5efa8
to
88b8d70
Compare
Updated to make call to |
Synopsis of changes: