Skip to content

Commit

Permalink
Merge pull request #154 from RhoInc/v3.4.1
Browse files Browse the repository at this point in the history
v3.4.1
  • Loading branch information
pburnsdata authored Oct 21, 2020
2 parents 80b7a6e + 713e3ba commit 4ff6a1e
Show file tree
Hide file tree
Showing 8 changed files with 41 additions and 18 deletions.
20 changes: 13 additions & 7 deletions build/aeTable.js
Original file line number Diff line number Diff line change
Expand Up @@ -1747,13 +1747,19 @@
/////////////////////////////////////
//Check to make sure there is some data
if (!chart.data.major.length) {
chart.wrap
.select('.SummaryTable')
.append('div')
.attr('class', 'wc-alert')
.text(
'Error: No AEs found for the current filters. Update the filters to see results.'
);
chart.wrap.select('.SummaryTable').append('div').attr('class', 'wc-alert').text(
!chart.population_data.length
? 'Error: No subjects found for the current filters. Update the filters to see results.'
: 'Error: No AEs found for the ' +
d3
.set(
chart.population_data.map(function(d) {
return d[chart.config.variables.id];
})
)
.values().length +
' subjects selected by the current filters. Update the filters to see results.'
);
throw new Error('No data found in the column specified for major category. ');
}

Expand Down
4 changes: 2 additions & 2 deletions build/aeTable.min.js

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "aeexplorer",
"version": "3.4.0",
"version": "3.4.1",
"description": "An interactive tool that allows users to dynamically query adverse event data in real time.",
"keywords": [
"adverse",
Expand Down
2 changes: 1 addition & 1 deletion scripts/configuration.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Renderer-specific settings
The sections below describe each aeexplorer setting as of version 3.4.0.
The sections below describe each aeexplorer setting as of version 3.4.1.

## settings.variables
`object`
Expand Down
2 changes: 1 addition & 1 deletion settings-schema.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"title": "config",
"description": "JSON Schema for AE Explorer configuration. Last updated with v3.1.1 release.",
"version": "3.4.0",
"version": "3.4.1",
"type": "object",
"properties": {
"variables": {
Expand Down
7 changes: 6 additions & 1 deletion src/chart/AETable/init.js
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,12 @@ export function init(chart) {
.append('div')
.attr('class', 'wc-alert')
.text(
'Error: No AEs found for the current filters. Update the filters to see results.'
!chart.population_data.length
? 'Error: No subjects found for the current filters. Update the filters to see results.'
: `Error: No AEs found for the ${d3
.set(chart.population_data.map(d => d[chart.config.variables.id]))
.values()
.length} subjects selected by the current filters. Update the filters to see results.`
);
throw new Error('No data found in the column specified for major category. ');
}
Expand Down
14 changes: 13 additions & 1 deletion test-page/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,19 @@ d3.csv(

var settings = {
variables: {
group: 'ARM'
group: 'ARM',
filters: [
{
value_col: 'SITE',
label: 'Site',
type: 'participant'
},
{
value_col: 'AESER',
label: 'Serious',
type: 'event'
}
]
},
variableOptions: {
group: ['SEX', 'RACE', 'SITE', 'ARM']
Expand Down

0 comments on commit 4ff6a1e

Please # to comment.