Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Numerator not using subset #122

Closed
pburnsdata opened this issue Apr 2, 2019 · 1 comment
Closed

Numerator not using subset #122

pburnsdata opened this issue Apr 2, 2019 · 1 comment
Labels
bug Something isn't working
Milestone
v1.2.3

Comments

@pburnsdata
Copy link
Contributor

Currently CRFs with denominators are not using the subset in their denominator. TBH the name denominator may be misleading anyways. Really it's a subset used for both the numerator and denominator.
@pburnsdata pburnsdata added the bug Something isn't working label Apr 2, 2019
@pburnsdata pburnsdata mentioned this issue Apr 2, 2019
Merged
@emmorris emmorris added this to the v1.2.3 milestone Apr 2, 2019
@emmorris
Copy link

emmorris commented Apr 2, 2019

Note: This was only affecting the Source Data Verified and Signed columns. The code change was very small and was isolated to the percentage calculation for those two columns.

@pburnsdata pburnsdata mentioned this issue Apr 2, 2019
Open
pburnsdata added a commit that referenced this issue Apr 25, 2019
@pburnsdata
restore #122 fix that got lost
63032b0
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.2.3
Development

No branches or pull requests
2 participants
@emmorris @pburnsdata