Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ISSUE#149] MXN fraction changed to 4 #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laughing-nerd
Copy link

@laughing-nerd laughing-nerd commented Oct 4, 2024

I have addressed issue#149 and changed the fraction for MXN from 2 to 4. Please review the PR and let me know if any other changes are required.

Summary by Sourcery

Update the MXN currency fraction from 2 to 4 in the currency configuration to resolve issue #149.

Bug Fixes:

Copy link

sourcery-ai bot commented Oct 4, 2024

Reviewer's Guide by Sourcery

This pull request addresses issue #149 by changing the fraction for the Mexican Peso (MXN) currency from 2 to 4 in the currency.go file. This is a simple, focused change that affects only one line of code.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated the fraction for Mexican Peso (MXN) from 2 to 4
  • Changed the Fraction value from 2 to 4 for the MXN currency in the currencies map
currency.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @laughing-nerd - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a brief comment explaining why MXN uses 4 decimal places instead of the more common 2. This will help future maintainers understand the reasoning behind this specific configuration.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Rhymond
Copy link
Owner

Rhymond commented Oct 9, 2024

Can you include official reference where it states of MXN currency fraction?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants