Retrieve attributes only once in SystemTextJsonReflectionService.Gene…

…rateProperties
RicoSuter · Nov 24, 2024 · fa484cf · fa484cf
1 parent 1a7c0ec
commit fa484cf
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/src/NJsonSchema/Generation/SystemTextJsonReflectionService.cs b/src/NJsonSchema/Generation/SystemTextJsonReflectionService.cs
@@ -50,9 +50,8 @@ public override void GenerateProperties(JsonSchema schema, ContextualType contex
                 }
 
                 var propertyIgnored = false;
-                var jsonIgnoreAttribute = accessorInfo
-                    .GetAttributes(true)
-                    .FirstAssignableToTypeNameOrDefault("System.Text.Json.Serialization.JsonIgnoreAttribute", TypeNameStyle.FullName);
+                var attributes = accessorInfo.GetAttributes(true).ToArray();
+                var jsonIgnoreAttribute = attributes.FirstAssignableToTypeNameOrDefault("System.Text.Json.Serialization.JsonIgnoreAttribute", TypeNameStyle.FullName);
 
                 if (jsonIgnoreAttribute != null)
                 {
@@ -65,9 +64,8 @@ public override void GenerateProperties(JsonSchema schema, ContextualType contex
 
                 var ignored = propertyIgnored
                     || schemaGenerator.IsPropertyIgnoredBySettings(accessorInfo)
-                    || accessorInfo.GetAttributes(true)
-                        .FirstAssignableToTypeNameOrDefault("System.Text.Json.Serialization.JsonExtensionDataAttribute", TypeNameStyle.FullName) != null
-                    || settings.ExcludedTypeNames.Contains(accessorInfo.AccessorType.Type.FullName);
+                    || attributes.FirstAssignableToTypeNameOrDefault("System.Text.Json.Serialization.JsonExtensionDataAttribute", TypeNameStyle.FullName) != null
+                    || Array.IndexOf(settings.ExcludedTypeNames, accessorInfo.AccessorType.Type.FullName) != -1;
 
                 if (!ignored)
                 {
@@ -87,9 +85,7 @@ public override void GenerateProperties(JsonSchema schema, ContextualType contex
                         }
                     }
 
-                    var requiredAttribute = accessorInfo
-                        .GetAttributes(true)
-                        .FirstAssignableToTypeNameOrDefault("System.ComponentModel.DataAnnotations.RequiredAttribute");
+                    var requiredAttribute = attributes.FirstAssignableToTypeNameOrDefault("System.ComponentModel.DataAnnotations.RequiredAttribute");
 
                     var isDataContractMemberRequired = schemaGenerator.GetDataMemberAttribute(accessorInfo, contextualType.Type)?.IsRequired == true;