Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reimplemented CrashRpt #1248

Merged
merged 1 commit into from
Nov 20, 2016
Merged

Reimplemented CrashRpt #1248

merged 1 commit into from
Nov 20, 2016

Conversation

AnotherFoxGuy
Copy link
Member

@AnotherFoxGuy AnotherFoxGuy commented Nov 16, 2016

Quote the OS-X compile wiki page

Rigs of Rods is a complex beast. It has a 3D engine, physics simulator, water and sky plug-ins, input device system, networking, localisation plug-in module... and so on.

And because of that, it is useful to have a crash reporter because there are allot of things that can go wrong.
It can also help in fixing hard to reproduce crashes such as #1241

@ohlidalp
Copy link
Member

ohlidalp commented Nov 16, 2016

💯

I took a quick look at the crashfix installation you did. Login page looks OK, except the homepage (click the logo) yields HTTP 500 for some reason: http://crashfix.rigsofrods.org/index.php - at least for me at work (Win7 Pro SP1, x64, Firefox 40.0.2)

TODO: Port the "policy" wikipage to new docs and fix the http://wiki.rigsofrods.com/pages/Crash_Report_Privacy_Policy link.

Please make a CrashFix account for me and give me a day to test everything out.

@AnotherFoxGuy
Copy link
Member Author

TODO: Port the "policy" wikipage to new docs and fix the http://wiki.rigsofrods.com/pages/Crash_Report_Privacy_Policy link.

Done: RigsOfRods/docs.rigsofrods.org#7

Please make a CrashFix account for me and give me a day to test everything out.

And done 😃

@ohlidalp
Copy link
Member

ohlidalp commented Nov 20, 2016

Build issue: CrashRpt CMakeLists.txt seems to be hardcoded to generate lib/dll names with version included:

if(CRASHRPT_BUILD_SHARED_LIBS)
    set_target_properties(CrashRpt PROPERTIES 
                                    DEBUG_POSTFIX ${CRASHRPT_VER}d 
                                    RELEASE_POSTFIX ${CRASHRPT_VER} )

For me, this yielded CrashRpt1403.lib/exp/dll, but RoR's CMake is looking for CrashRpt.lib/dll.

Did you observe the same issue? How did you solve it?

EDIT: CrashRpt requires "CrashSender{VER}.exe" to be present in RoR directory. Our Cmakescripts should pul it from dependencies/CrashRpt/bin, but there's no such logic. I added the EXE manually.

EDIT2: same thing with crashrpt_lang.ini

@AnotherFoxGuy
Copy link
Member Author

AnotherFoxGuy commented Nov 20, 2016

For me, this yielded CrashRpt1403.lib/exp/dll, but RoR's CMake is looking for CrashRpt.lib/dll.
Did you observe the same issue? How did you solve it?

You only have to rename CrashRpt1403.lib to CrashRpt.lib and put it in dependencies\libs\x86\CrashRpt\Release

CrashRpt requires "CrashSender{VER}.exe" to be present in RoR directory. Our Cmakescripts should pul it from dependencies/CrashRpt/bin, but there's no such logic. I added the EXE manually.

There is, but the path is dependencies\bin\x86\CrashRpt\Release instead of dependencies/CrashRpt/bin

@ohlidalp
Copy link
Member

ohlidalp commented Nov 20, 2016

There is, but the path should be \dependencies\bin\x86\CrashRpt\Release instead of dependencies/CrashRpt/bin

I downloaded the AppVeyor dep-pack from dl.rigsofrods.org and figured that out. And yes, the path is incorrect, it was just an illustration.

One thing still puzzles me - the dep-pack has libs under dependencies.7z\libs\x86\CrashRpt\* although Cmake looks under DEPS\libs\x86\CrashRpt\Release\*

EDIT: Does CrashRpt require a RelWithDebInfo build, or does it work with Release build?
EDIT2: I assume it works with both, except there's more stack trace info with debuginfo available (I'm looking at the "Multyplayer crash" in our CrashFix 😄 )

@AnotherFoxGuy AnotherFoxGuy merged commit 81c2f93 into RigsOfRods:master Nov 20, 2016
@AnotherFoxGuy AnotherFoxGuy deleted the return-of-the-CrashRpt branch November 20, 2016 16:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants