Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed static reflection map being black. #2721

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

ohlidalp
Copy link
Member

@ohlidalp ohlidalp commented Mar 29, 2021

Intro

we have 2 cvars (RoR.cfg entries):

  • gfx_envmap_enabled("Reflections"): bool - if true, reflections are dynamically updated. If false, they're static but still visible (counter intuitive but classic behavior).
  • gfx_envmap_rate("ReflectionUpdateRate"): integer, 0-6: how many of the 6 dynamic textures to update every frame? 0 is equivalent to "Reflections=No" in RoR.cfg. This has severe impact on FPS.

Problem

With "Reflections=No", the reflection map was black. This caused reflective surfaces to be very dark.

Solution

Even if disabled in config, the realtime envmap is fully rendered once after loading terrain, to provide static reflections.

Kudos to NegativeIce for reporting!

Even if disabled in config, the realtime envmap is fully rendered once after loading terrain, to provide static reflections.

Kudos to NegativeIce for reporting!
@ohlidalp ohlidalp requested a review from tritonas00 March 29, 2021 20:55
@tritonas00
Copy link
Collaborator

Works fine. Merging so Neg can test also.

@tritonas00 tritonas00 merged commit 82689ca into RigsOfRods:master Mar 30, 2021
@tritonas00
Copy link
Collaborator

With "Reflections=No", the reflection map was black.

Was actually:

With "Reflections=Yes , ReflectionUpdateRate=0", the reflection map was black.

@ohlidalp ohlidalp deleted the envmap-off branch April 27, 2021 19:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants