-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Menu cleanups and improvements #2723
Conversation
Works great, just one detail: the "cache updated" notification only shows if cache is actually updated. If it's already up-to-date and user presses "update cache" button, nothing shows at all. I suggest adding "cache is up-to-date" variant of the notification for this case. |
this is not the case on linux, it is always shown when i hit the update cache button |
@tritonas00 I don't understand why linux behaves differently, but we definitely have a bug: CACHE_STATE_UNKNOWN and CACHE_NEEDS_UPDATE have the same value. Without this bug, the notification would always display after pressing the button. UPDATE: I fixed the bug (and couple others I noticed), "cache updated" now displays the way you intended. Please merge these commits https://github.com/only-a-ptr/rigs-of-rods/commits/menu-cleanup and test again. |
Because `int n = 0xFFFFFFFF` is the same thing as `int n = -1`. Also modernized code.
GUI_GamePauseMenu(cpp/h)
and merged code inGUI_GameMainMenu.cpp