Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Menu cleanups and improvements #2723

Merged
merged 6 commits into from
Apr 5, 2021
Merged

Conversation

tritonas00
Copy link
Collaborator

@tritonas00 tritonas00 commented Mar 30, 2021

  • Removed GUI_GamePauseMenu(cpp/h) and merged code in GUI_GameMainMenu.cpp
  • Pressing Esc in multiplayer, only the menu is shown now, simulation continues
  • Added "Cache updated" notice:
    kk

@ohlidalp
Copy link
Member

ohlidalp commented Apr 5, 2021

Works great, just one detail: the "cache updated" notification only shows if cache is actually updated. If it's already up-to-date and user presses "update cache" button, nothing shows at all. I suggest adding "cache is up-to-date" variant of the notification for this case.

@tritonas00
Copy link
Collaborator Author

notification only shows if cache is actually updated. If it's already up-to-date and user presses "update cache" button, nothing shows at all

this is not the case on linux, it is always shown when i hit the update cache button
i can reproduce the issue on windows, i moved the notice to LoadModCache, also the same

@ohlidalp
Copy link
Member

ohlidalp commented Apr 5, 2021

@tritonas00 I don't understand why linux behaves differently, but we definitely have a bug: CACHE_STATE_UNKNOWN and CACHE_NEEDS_UPDATE have the same value. Without this bug, the notification would always display after pressing the button.

UPDATE: I fixed the bug (and couple others I noticed), "cache updated" now displays the way you intended. Please merge these commits https://github.com/only-a-ptr/rigs-of-rods/commits/menu-cleanup and test again.

@tritonas00
Copy link
Collaborator Author

Epic

kk

@tritonas00 tritonas00 merged commit 306bc44 into RigsOfRods:master Apr 5, 2021
@tritonas00 tritonas00 deleted the menu-cleanup branch April 5, 2021 18:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants