-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Added flare type 'd' (dashboard indicator) #2735
Conversation
Removed `RigDef::Flare2::Type`, using directly `FlareType` from SimData.h
Functions defined in class body are inline by default. The pass-by-reference args were confusing and might actually hurt performance.
CODECHANGES: DashBoardManager.h - added new enum field DD_SIGNAL_WARNING, commented the other DD_SIGNAL* DashBoardManager.cpp - added data init for the new "signal_warning" Actor.h - removed the `m_blinker*_lit` vars Actor.cpp - update dashboard DD_SIGNAL* data directly. also update the new "signal_warning". OutGauge.cpp - read data from dashboard instead of the removed vars. ActorManager.cpp - minor - just renamed one function.
Instead of control number, you specify an input source from our dashboard system, see https://docs.rigsofrods.org/vehicle-creation/making-custom-hud/#input-sources All "bool" input sources are supported: ``` flares 7,3,6, 0.12, 0.3 d engine_ignition 7,3,6, 0.45, 0.3 d engine_battery 7,3,6, 0.72, 0.3 d engine_clutch_warning 7,3,6, 0.12, 0.15 d parkingbrake 7,3,6, 0.28, 0.15 d locked 7,3,6, 0.45, 0.15 d low_pressure 7,3,6, 0.68, 0.15 d signal_warning ```
Implemented via dashboard flare 'd parkingbrake'
Works as advertised ❤️ |
In your display, you show a |
Also, closes #2553 |
@willmichals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes looks good and clear.
My friends who initially made me aware of the issue said it`s fixed.
Changes:
Example:
Demonstration:
Test vehicle: flareboard.zip