Settings UI now uses actual tabs #2747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"update cache" button moved under "General".
|
Looks good. Thoughts on changing some of the Render System settings to checkboxes instead of dropdowns? Such as DirectX9Ex, Full Screen, and VSync? |
|
Nice. Is it possible for the tabs to not scroll with the rest of the body? |
Yes, I'll change it.
It works by looping over OGRE's list of settings and possible values. I'd keep it as is for simplicity. |
|
|
Zentro
approved these changes
May 5, 2021
tritonas00
approved these changes
May 5, 2021
|
I just noticed you can scroll the tabs. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Update cache" button moved under "General".
Separated "Simulation settings" from "General" to it's own tab "Gameplay".