Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Hotfixes #2756

Merged
merged 6 commits into from
Aug 22, 2021
Merged

Hotfixes #2756

merged 6 commits into from
Aug 22, 2021

Conversation

ohlidalp
Copy link
Member

@ohlidalp ohlidalp commented May 19, 2021 •
edited
Loading

4 unrelated UX improvements.

"Fresh" category restored to orig. formula: max 1 day since install.

@tritonas00
Copy link
Collaborator

tritonas00 commented May 20, 2021 •
edited
Loading

Can you also do something about the Unsorted selector category? The count number appears correct but it actually shows all mods

@ohlidalp
Copy link
Member Author

@tritonas00 Can you also do something about the Unsorted selector category? The count number appears correct but it actually shows all mods

Fixed. Good spot.

@tritonas00
Copy link
Collaborator

tritonas00 commented May 22, 2021 •
edited
Loading

Great! Found another one. Load a map, open selector, select Aircraft category, press Cancel. Go to main menu, load map again, open selector:

kk

@ohlidalp
Copy link
Member Author

@tritonas00 Found another one. Load a map, open selector, select Aircraft category, press Cancel. Go to main menu, load map again, open selector:

Fixed

@tritonas00
Copy link
Collaborator

tritonas00 commented Aug 17, 2021 •
edited
Loading

Its good. One more thing. Open selector, select a category (Aircraft) and open the category menu again -> Fresh category from X number (5 here) went to 0.

@ohlidalp
🐛 Fixed pause menu appearing if quickload fails.
ca731d5
@ohlidalp
🐛 Selector UI: only display 'Vehicle type' for vehicles.
1c2ad17
@ohlidalp
🐛 Do not display FATAL ERROR on missing TractionMap file (isn't fatal).
7a1a568
@ohlidalp
🐛 Fixed "unsorted" category in loader UI.
aebb2ac 
Problem: The count number appears correct but it actually shows all mods

Fix: instead of treating all CID_* categories as "show all", do specific handling for each type.
@ohlidalp
🐛 Fixed category mixup in LoaderUI
e8b79f6
@ohlidalp
🐛 "Fresh" category restored to orig. formula: max 1 day since install.
09160fb 
Broken by eb91d9c - since then, freshness was evaluated based on file/ZIP last modified time.
The preceding logic was also somewhat complicated - I think the formula was "max 1 day since last cache update which added content", but I'm not sure.
Anyway, I restored it to match v0.4.0.7 (year 2013) - Let's gather new feedback.
@ohlidalp
Copy link
Member Author

@tritonas00 One more thing. Open selector, select a category (Aircraft) and open the category menu again -> Fresh category from X number (5 here) went to 0.

Fixed, and also reverted the "Fresh" category formula to old form - see commit desc.

@tritonas00
Copy link
Collaborator

Works great now 👍

@ohlidalp ohlidalp merged commit f041c1e into RigsOfRods:master Aug 22, 2021
@ohlidalp ohlidalp deleted the hotfix branch August 22, 2021 10:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Zentro Zentro Zentro approved these changes

@WillyB1337 WillyB1337 WillyB1337 approved these changes

@tritonas00 tritonas00 tritonas00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ohlidalp @tritonas00 @WillyB1337 @Zentro