Multiplayer improvements #2760

tritonas00 · 2021-05-27T08:19:54Z

You can now remove your own actors and hide/unhide remote actors (useful if someone lags you) from top menu bar in multiplayer.

Also net labels remade using ImGui.

Closes #2497
Fixes #2622
Fixes #479

Thanks Petr for the help!

ohlidalp · 2021-06-12T11:53:47Z

Oops.

I'm coding a fix

ohlidalp · 2021-06-12T13:04:20Z

As usual, this was harder than it should be. Please cherrypick the last 2: https://github.com/only-a-ptr/rigs-of-rods/commits/mp-actor-list

ohlidalp · 2021-06-27T22:21:13Z

The only thing I found left is MP labels. While testing I noticed Unicode is completely broken - characters don't display at all. To kill 2 bugs with one blow, I made a prototype of drawing the labels with DearIMGUI.

@tritonas00 you'll have to pick from here...

to fix size, use the one calculated but multiply with e.g. 40. the original value is 0 - 0.6, but imgui needs it in pixels.
to give the text some highlight, use drawlist->AddQuad() to put darker rectangle around the text.
Finally, text centering needs to be fixed, currently drawn all to the right from the correct spot.

💤

tritonas00 · 2021-06-28T01:25:10Z

The only thing I found left is MP labels

and turbojet/props

Nice one with imgui labels, will definitely check it out

ohlidalp · 2021-08-23T21:34:14Z

I centered and visually improved the labels.

But I also noticed a bug (exists in master) - when you join while existing player is already in vehicle, the character will not appear in the vehicle but somewhere far below the map. This was never noticed because the old label would not be visible (too small or clipped).

source/main/physics/air/TurboProp.cpp

Mostly just find&replace, except: 1. Moved enumeration `Actor::SimState` from "Actor.h" to "SimData.h" and renamed to `ActorState` . 2. Actor.h: Renamed `Actor::ar_sim_state` to `Actor::ar_state`, added include Differentials. 3. Differentials.h/cpp: added namespace RoR

TODO: text color, highlight and distance-resizing.

Added common drawing function `App::GetGfxScene()->DrawNetLabel()`

Fixed `m_disable_smoke` field - now valid to be changed in real time, previously mixed - would affect exhausts but not turbojets.

tritonas00 force-pushed the mp-actor-list branch from 463bbae to 35dd14d Compare June 10, 2021 17:57

tritonas00 changed the title ~~Added ability to remove actors in multiplayer~~ Added ability to hide/unhide/remove actors in multiplayer Jun 10, 2021

tritonas00 force-pushed the mp-actor-list branch from df7c6aa to 19972b6 Compare June 12, 2021 15:54

tritonas00 changed the title ~~Added ability to hide/unhide/remove actors in multiplayer~~ Multiplayer improvements Jun 29, 2021

ohlidalp force-pushed the mp-actor-list branch from a856e45 to 17fdcd6 Compare August 23, 2021 21:24

ohlidalp force-pushed the mp-actor-list branch from eba3045 to 5ad145a Compare August 23, 2021 21:37

tritonas00 commented Aug 28, 2021

View reviewed changes

source/main/physics/air/TurboProp.cpp Show resolved Hide resolved

ohlidalp force-pushed the mp-actor-list branch 2 times, most recently from 6297266 to 37c6a32 Compare August 28, 2021 21:08

ohlidalp force-pushed the mp-actor-list branch from 37c6a32 to 532f94f Compare September 13, 2021 20:19

tritonas00 force-pushed the mp-actor-list branch 5 times, most recently from 3e4f4c9 to 9df64f4 Compare September 14, 2021 19:56

tritonas00 and others added 10 commits September 16, 2021 10:51

added hide/unhide/remove buttons in mp actor list

009bcf6

use eject button

6f01450

🔧 when hiding remote vehicle, also hide seated character.

65e3c3a

Fixed character appearing even if vehicle has no driverseat!

fd13413

use X for remove button, mute/unmute sounds, alligned buttons

81cb689

hide lights

e925527

fixed remote actor not unregistering when hidden

f6604af

hide wings

8187fed

hide airbrakes

7dcdb9a

ohlidalp and others added 14 commits September 16, 2021 10:53

🏷️ MP labels are now drawn by DearIMGUI (prototype).

1911bc0

TODO: text color, highlight and distance-resizing.

📐 (minor) Rem. redundant namespace qualifier

448aae7

🏷️ Character net labels also drawn by DearIMGUI

b322a87

Added common drawing function `App::GetGfxScene()->DrawNetLabel()`

🏷️ Net. labels now colored and highlighted.

b9c0320

use AddRectFilled, rounded corners

f54ab47

🏷️ DearIMGUI net labels - corrected centering.

04a2edf

🗑️ Rem. unused MovableText - now using DearIMGUI.

b8ad1b8

🗑️ Rem. unused MovableText from Actor - using imgui.

e8b71d7

Removed dupli. code - SetAllMeshesVisible() handles that.

cde43f8

Code cleanup - do more in SetAllMeshesVisible()

39274ee

📐 Big re-format of GfxActor.h, grouped functions.

86ecc5b

🔧 Ability to hide aeroengines

1d188f2

Actor: added get/setSmokeEnabled() for ad-hoc use.

1194484

Fixed `m_disable_smoke` field - now valid to be changed in real time, previously mixed - would affect exhausts but not turbojets.

fixes

13c9158

tritonas00 force-pushed the mp-actor-list branch from 9df64f4 to 13c9158 Compare September 16, 2021 07:55

tritonas00 merged commit f31d7f8 into RigsOfRods:master Sep 16, 2021

tritonas00 deleted the mp-actor-list branch September 16, 2021 15:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multiplayer improvements #2760

Multiplayer improvements #2760

tritonas00 commented May 27, 2021 •

edited

Loading

ohlidalp commented Jun 12, 2021

ohlidalp commented Jun 12, 2021

ohlidalp commented Jun 27, 2021

tritonas00 commented Jun 28, 2021

ohlidalp commented Aug 23, 2021 •

edited

Loading

Multiplayer improvements #2760

Multiplayer improvements #2760

Conversation

tritonas00 commented May 27, 2021 • edited Loading

ohlidalp commented Jun 12, 2021

ohlidalp commented Jun 12, 2021

ohlidalp commented Jun 27, 2021

tritonas00 commented Jun 28, 2021

ohlidalp commented Aug 23, 2021 • edited Loading

tritonas00 commented May 27, 2021 •

edited

Loading

ohlidalp commented Aug 23, 2021 •

edited

Loading