Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed races not loading when event type is not defined #2796

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

tritonas00
Copy link
Collaborator

@tritonas00 tritonas00 commented Sep 16, 2021

Old code was:
kk
2046c33

Fixes #2745

@only-a-ptr Is this correct or we need to be specific? Like

if strncmp(ev_type, "",  0)

@ohlidalp
Copy link
Member

@tritonas00 Is this correct or we need to be specific? like if strncmp(ev_type, "", 0)

Let's leave it like it is, I think it's the best solution.

The old parser was somewhat messy here - If the filter-string was bogus but not empty, the filter would be set to value of previous event filter (or EVENT_ALL for the very first event line). But I think this is an old bug and it really should behave the way you made it just now.

Copy link
Member

@ohlidalp ohlidalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@tritonas00 tritonas00 merged commit ec84655 into RigsOfRods:master Sep 16, 2021
@tritonas00 tritonas00 deleted the race-fix branch September 16, 2021 15:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Races not working correctly in 2021.02/.04
2 participants