Fixed skinned vehicles showing pink after reload #2872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed stray line accidentally duplicated from ReLoadResource() in 28f2cf0
Fixes RigsOfRods#2864 CacheEntries often share the same resoruce bundle (think multiple .truck or .skin files in one ZIP). In that case, their 'resource_group' member variable should always be in sync. This was done properly in UnLoadResource() but not in LoadResource().
tritonas00
approved these changes
Mar 17, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resource management is hard.
There's usually more than one .truck and possibly several .skin entries in a ZIP file from the repo. Modcache creates a
CacheEntryfor each of these, and it must keep them in sync - when one is loaded, the others must be notified. This was hapenning correctly on unloading, but not on (re)loading.