Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fixed visual glitches with PSSM #2876

Merged
merged 1 commit into from
Mar 19, 2022
Merged

Fixed visual glitches with PSSM #2876

merged 1 commit into from
Mar 19, 2022

Conversation

tritonas00
Copy link
Collaborator

@tritonas00 tritonas00 commented Mar 18, 2022 •
edited
Loading

  • Fixes character color glitch with PSSM
    Managed to reproduce the issue on my laptop, it also happens with VS 2019
    Before:
    bef
    After:
    af
  • Fixes PSSM glitch (see attached GIF) #361. It happens with new materials, PSSM and reflections on
    Before:
    screenshot_2022-03-19_17-46-05_1
    After:
    screenshot_2022-03-19_17-46-33_1

Reference: https://ogrecave.github.io/ogre/api/13/_material-_scripts.html#autotoc_md131

@tritonas00 tritonas00 marked this pull request as draft March 18, 2022 18:19
@AnotherFoxGuy
Copy link
Member

Would adding depth_bias to the shadows material also fix #361 ?

AnotherFoxGuy
AnotherFoxGuy approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@AnotherFoxGuy AnotherFoxGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fixes the shirt in multiplayer

@tritonas00
Copy link
Collaborator Author

tritonas00 commented Mar 19, 2022 •
edited
Loading

Would adding depth_bias to the shadows material also fix #361 ?

Reproduced on my laptop, it happens with PSSM on + new materials (not classic) + reflections on

Adding depth_bias -20 after https://github.com/RigsOfRods/rigs-of-rods/blob/master/resources/managed_materials/shadows/pssm/on/shadows.material#L4 fixes both issues

@tritonas00 tritonas00 changed the title Fixed character color glitch with PSSM Fixed visual glitches with PSSM Mar 19, 2022
@tritonas00 tritonas00 marked this pull request as ready for review March 19, 2022 16:03
@ohlidalp
Copy link
Member

Works perfectly.

@ohlidalp ohlidalp merged commit 77caa97 into RigsOfRods:master Mar 19, 2022
@tritonas00 tritonas00 deleted the pssm-glitch branch March 19, 2022 22:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@AnotherFoxGuy AnotherFoxGuy AnotherFoxGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PSSM glitch (see attached GIF)
3 participants
@tritonas00 @AnotherFoxGuy @ohlidalp