Added hydro flag j, restored bug with i for backw. compat.
#2933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tritonas00
approved these changes
Sep 2, 2022
It turns out the `i` flag has a bug: it always makes the hydro invisible, but if it comes as first/single flag, then it also makes the hydro commanded by steering input. That means: * `ri` will make the hydro respond only to airplane rudder, and invisible. * `ir` will make the hydro respond to both airplane rudder and steering input, and invisible. To resolve backward compatibility, I added a new flag `j`, which makes the hydro invisible but without the quirks of `i`. The documentation https://docs.rigsofrods.org/vehicle-creation/fileformat-truck/#hydros needs to be updated: * `` no flags given -> force `n` flag. * `n` means Normal and makes the hydro driven by steering input. and the above.
ohlidalp
force-pushed
the
hydro-compat
branch
from
db09ff0 to
e1295ce
Compare
|
Test using this vehicle (all hydros have
Note it got broken in 9421c68 - if you build an earlier commit, it will work the same way as in this PR. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out the
iflag has a bug: it always makes the hydro invisible, but if it comes as first/single flag, then it also makes the hydro commanded by steering input. That means:riwill make the hydro respond only to airplane rudder, and invisible.irwill make the hydro respond to both airplane rudder and steering input, and invisible. This makes it behave a lot different than plain hydro though, and many SimMonsters mods use it as a feature.To resolve backward compatibility, I added a new flag
j, which makes the hydro invisible but without the quirks ofi. The parser still recognizesibut internally I'm using onlyjandn.The documentation https://docs.rigsofrods.org/vehicle-creation/fileformat-truck/#hydros needs to be updated:
nflag.nmeans Normal and makes the hydro driven by steering input.jmakes the hydro invisible.imakes the hydro invisible, but BEWARE: if it comes as first/single flag, then it also forcesnflag. This quirk is maintained for backwards compatibility.Fixes #2932