Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

🐛 Fixed error handling when running multithreaded #15

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

AnotherFoxGuy
Copy link
Member

Patch applied from RigsOfRods/ror-server@b455cec

Removed variable SWBaseSocket::error_string which was written on any error and read on error in disconnect(), all without synchronization. This is a problem in Rigs of Rods server which uses each client socket from 2 threads: receiver and broadcaster.
Function SWBaseSocket::set_error() was modified to only fill the supplied SWBaseError object, without touching anything in the SWBaseSocket object. Also, the function won't shut down the whole program with exit() anymore.
"verbose mode" was removed completely.

@tritonas00
Copy link

Fixes RigsOfRods/rigs-of-rods#1279

@AnotherFoxGuy AnotherFoxGuy merged commit a437a35 into RigsOfRods:master Mar 18, 2022
@AnotherFoxGuy AnotherFoxGuy deleted the fix-err branch March 18, 2022 09:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants