New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[417] toggle warnings icon fixes #419

Merged

oceancabbage merged 1 commit into main from 417_toggle_warnings_fixes

Jun 19, 2024

Collaborator

oceancabbage commented Jun 19, 2024

Small improvements for the "toggle warning icon" feature:

Adding debug statement when a toggle happens
Toggling "off" the last warning while errors exist (or the last error while warnings exist) does not remove the summary text for warnings (or errors) due to the if/else logic. Fixing so this is behaving as expected.
Toggling "off" version mismatch errors does not remove the summary text due to missing a condition. Fixing so this is behaving as expected.

Testing: manually tested on my Windows machine


          [417] toggle warnings icon fixes

4972fa7

oceancabbage requested review from LionelColaso, twstagg and hk21702

June 19, 2024 05:14

oceancabbage mentioned this pull request

FIXME: clicking on warning icon deletes it from the UI and error summary #417

Closed

hk21702 approved these changes

View reviewed changes

Collaborator

hk21702 left a comment

Looks good.

I'd consider maybe also turning the "Toggle Warnings" context action into a checkable action while you're at it.

oceancabbage merged commit ece4989 into main

22 of 26 checks passed

oceancabbage deleted the 417_toggle_warnings_fixes branch

June 19, 2024 20:24

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet