Large refactor around reconcile workflow #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to find out whether we need to explicitly requeue.
Names are still confusing though
- Consistent naming scheme. - Improved comments - Consistent logs
Working but needs a lot of work...
- Stop passing dynamicenv object
- As a result of the above step I had to move StatusHandler to
StatusManager to avoid import cycles - it was not a handler to begin
with...
Just to be consistent with status manager.
Now that we created a way to add error only if not set, no need for double implementation.
babysnakes
requested review from
nissanitz,
ValorHeart and
yonathan-shtekel
as code owners
- do not nil as context - unused function
For some reason without anything changing, it added a link to 'subsettype' :(
nissanitz
reviewed
Feb 20, 2024
pkg/model/cleanup_manager.go
Outdated
| // CleanupManager is a handler that deals with removing DynamicEnv resources. | ||
| type CleanupManager struct { | ||
| client.Client | ||
| Ctx context.Context |
There was a problem hiding this comment.
Context should be passed via a parameter to function.
This also reverts the need to configure crd docs generator.
nissanitz
approved these changes
Feb 20, 2024
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major controller modifications around
Reconcileloop.