Bindings CRoaring 3.0, including 64 bit bitmaps #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
Man I love differential fuzzing. Finding some issues in roaring64, and our treemap: #126, RoaringBitmap/CRoaring#552, RoaringBitmap/CRoaring#550, RoaringBitmap/CRoaring#551 |
Dr-Emann
force-pushed
the
roaring64
branch
2 times, most recently
from
c9867b4 to
dea654b
Compare
Dr-Emann
force-pushed
the
roaring64
branch
10 times, most recently
from
1a05364 to
d7cf56c
Compare
Dr-Emann
force-pushed
the
roaring64
branch
2 times, most recently
from
e2dd6a8 to
b112e7e
Compare
Dr-Emann
force-pushed
the
roaring64
branch
3 times, most recently
from
97b75be to
8779205
Compare
Dr-Emann
changed the title
Don't remove run compression for treemap since we don't support it in roaring64 yet
|
@saulius Believe this is ready 🎉 |
|
Woha, this is fascinating @Dr-Emann, great work! |
saulius
reviewed
Mar 29, 2024
| /// assert_eq!(first_over_50, ControlFlow::Break(100)); | ||
| /// ``` | ||
| #[inline] | ||
| pub fn for_each<F, O>(&self, f: F) -> ControlFlow<O> |
There was a problem hiding this comment.
Nice use of ControlFlow, very elegant!
saulius
reviewed
Mar 29, 2024
saulius
approved these changes
Mar 29, 2024
|
Looks great! Given this introduces changes to |
the fuzz_ops64 target includes deserializing, and performing actions on the bitmap too
croaring-sys definitely requires a major version bump, but croaring-rs shouldn't have any breaking changes, and cargo-semver-checks agrees
|
I believe we don't actually need a major version bump, I don't think there's any breaking changes (and That said, I'm not against a 2.0, especially since croaring just did a major version bump. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See CRoaring 3.0.0 release